Change error codes from 16-bit to varints #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes CONNECTION_CLOSE, STOP_SENDING, and RESET_STREAM to varint error codes. Fixes #2672
ianswett
added
design
martinthomson
requested changes
May 9, 2019
draft-ietf-quic-transport.md
Outdated
| @@ -5550,7 +5554,7 @@ The initial contents of this registry are tabulated in {{frame-types}}. | |||
| IANA \[SHALL add/has added] a registry for "QUIC Transport Error Codes" under a | |||
| "QUIC Protocol" heading. | |||
|
|
|||
| The "QUIC Transport Error Codes" registry governs a 16-bit space. This space is | |||
| The "QUIC Transport Error Codes" registry governs a 62-bit space. This space is | |||
| split into two spaces that are governed by different policies. Values with the | |||
There was a problem hiding this comment.
I think that we want to crib from the frame types (or other varint registries) when it comes to policies. There isn't really a "first byte" any more.
|
For consistency you probably want to update HTTP too, e.g. there are some references to 16-bit error code there too https://tools.ietf.org/html/draft-ietf-quic-http-20#section-10.5 |
|
Thanks for pointing that out @LPardue, http updated. |
MikeBishop
reviewed
May 10, 2019
Co-Authored-By: Mike Bishop <mbishop@evequefou.be>
Mike's suggestion, carrying -> containing
|
Thanks Mike, I think I fixed all your suggestions. |
janaiyengar
approved these changes
May 11, 2019
martinthomson
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes CONNECTION_CLOSE, STOP_SENDING, and RESET_STREAM to varint error codes.
Fixes #2672
Also fixes an error where the spec said the transport parameter registry is 16 bits, but transport parameters are now varints as well.